PopupView: fix top and bottom overflow

[RiccardoCampo]

Resolves: audacity/audacity#10660

Fix PopupView top and bottom overflow. Lower the popup if it's position overflows the window's height (and viceversa for bottom).

Previous attempts:

• fix(ui): make track ruler customize popup scrollable audacity/audacity#10871
• fix(track-ruler): make customize popup scrollable and prevent content… audacity/audacity#10875
• PopupView: fix top and bottom overflow #85

• I signed the CLA as camporcr:
• The title of the PR describes the problem it addresses.
• Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
• The code in the PR follows the coding rules.
• I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
• The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
• No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
• There are no unnecessary changes.
• I created a unit test or vtest to verify the changes I made (if applicable).

Build configuration

audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d3e30ecb-3fab-4633-a122-dc0932c3eaf6

📥 Commits

Reviewing files that changed from the base of the PR and between 20f30a5 and 23593ec.

📒 Files selected for processing (1)

• framework/uicomponents/qml/Muse/UiComponents/popupview.cpp

---

📝 Walkthrough

Walkthrough

PopupView::updateGeometry() now applies vertical boundary corrections after horizontal clamping. It moves the popup upward when its bottom exceeds the anchor. It moves the popup downward when its top is above the anchor.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the PopupView overflow fix addressed by the changes.
Description check	✅ Passed	The description includes the issue, motivation, prior attempts, checklist, and build configuration; only the optional test checkbox is unchecked.
Linked Issues check	✅ Passed	The vertical positioning changes address issue #10660 by keeping the track ruler settings popup accessible near the bottom of the interface.
Out of Scope Changes check	✅ Passed	The PR changes only PopupView geometry logic, which directly supports the linked overflow issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}