Skip to content

feat(CI): remove downloading of obsolete windows dependencies - #205

Merged
igorkorsukov merged 1 commit into
musescore:mainfrom
cbjeukendrup:ci-fixes
Aug 7, 2026
Merged

feat(CI): remove downloading of obsolete windows dependencies#205
igorkorsukov merged 1 commit into
musescore:mainfrom
cbjeukendrup:ci-fixes

Conversation

@cbjeukendrup

Copy link
Copy Markdown
Contributor

The only thing of it that still seemed used is JACK, but in reality it isn’t: JACK is not enabled on Windows, and the libs in the dependencies archive turn out to be 32-bit MinGW libs, so not usable anyway.
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7e4292c2-230c-4241-a43f-d6405c48f5ab

📥 Commits

Reviewing files that changed from the base of the PR and between 432d7ce and 118a05a.

📒 Files selected for processing (2)
  • buildscripts/ci/windows/build.bat
  • buildscripts/ci/windows/setup.bat
💤 Files with no reviewable changes (1)
  • buildscripts/ci/windows/setup.bat

📝 Walkthrough

Walkthrough

The Windows CI scripts no longer download or extract dependency archives. They no longer copy dependency or JACK files or update PATH for JACK. The build script retains standard and portable installation configuration and continues to invoke make_revision_env.sh.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only references a related pull request and omits the required summary, issue reference, checklist, and build configuration sections. Add the required issue reference, change summary, completed checklist, and build configuration section from the repository template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: removing obsolete Windows dependency downloads from CI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@igorkorsukov
igorkorsukov merged commit 20f30a5 into musescore:main Aug 7, 2026
3 checks passed
@cbjeukendrup
cbjeukendrup deleted the ci-fixes branch August 7, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants