Fix action icon colour to remain empty when invalid

[ajuncosa]

Resolves: musescore/MuseScore#34442

This fixes the actions icon colour, so that uses like: color: root.modelData?.iconColor || ui.theme.fontPrimaryColor - which assume an empty colour string - will remain working (otherwise they were getting a valid #000000 string instead of empty).

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c2a85fbb-5521-4f72-92a6-92264e8a0e0c

📥 Commits

Reviewing files that changed from the base of the PR and between 34210b4 and 116cae5.

📒 Files selected for processing (1)

• framework/ui/internal/uiactionsregister.cpp

---

📝 Walkthrough

Walkthrough

Command-derived UI actions now assign iconColor only when info.decoration.iconColor is valid. Invalid decoration colors no longer produce a converted color string.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description identifies issue #34442 and explains the fix, but it omits the required checklist and other template sections.	Add the required checklist with accurate checkbox states and complete any applicable template sections.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the fix for invalid action icon colors.
Linked Issues check	✅ Passed	The change preserves empty colors for invalid values and addresses the dark-mode icon color regression in issue #34442.
Out of Scope Changes check	✅ Passed	The three-line change is limited to action icon color handling and aligns with the linked issue objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[ajuncosa]

/build

[github-actions]

Build dispatched: https://github.com/musescore/muse_framework/actions/runs/31172161191