Fuzzy text search, part 2: Add fuzzy search to learn page - #197
Conversation
|
Warning Review limit reached
Next review available in: 27 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThe change adds a Qt playlist list model with playlist roles and duration formatting. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@framework/learn/qml/Muse/Learn/internal/playlistmodel.cpp`:
- Around line 48-50: Update PlaylistModel::rowCount to return zero when the
supplied parent QModelIndex is valid, while preserving m_playlist.size() for the
invalid root index used by this flat list model.
In `@framework/learn/qml/Muse/Learn/LearnPage.qml`:
- Around line 204-222: Update the LearnPage playlist flow around the
SortFilterProxyModel to pass whether a search is active into Playlist.qml, then
handle the zero-row state separately from load failure. When an active fuzzy
search has no matches, display a dedicated no-results message; preserve the
existing “unable to load these videos” message for genuine playlist loading
failures.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: ea3f57e1-6b74-42e3-8de8-02a6d6206ee8
📒 Files selected for processing (7)
framework/learn/qml/Muse/Learn/CMakeLists.txtframework/learn/qml/Muse/Learn/LearnPage.qmlframework/learn/qml/Muse/Learn/internal/Playlist.qmlframework/learn/qml/Muse/Learn/internal/playlistmodel.cppframework/learn/qml/Muse/Learn/internal/playlistmodel.hframework/learn/qml/Muse/Learn/learnpagemodel.cppframework/learn/qml/Muse/Learn/learnpagemodel.h
Refactors the playlist models to a QAbstractListModel subclass to allow the use of our SortFilterProxyModel.
5ff1a47 to
4833259
Compare
Part of: musescore/MuseScore#15983
Refactors the playlist models to a QAbstractListModel subclass to allow the use of our SortFilterProxyModel.