Skip to content

Fuzzy text search, part 2: Add fuzzy search to learn page - #197

Open
juli27 wants to merge 1 commit into
musescore:mainfrom
juli27:addFuzzySearchLearnPage
Open

Fuzzy text search, part 2: Add fuzzy search to learn page#197
juli27 wants to merge 1 commit into
musescore:mainfrom
juli27:addFuzzySearchLearnPage

Conversation

@juli27

@juli27 juli27 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Part of: musescore/MuseScore#15983

Refactors the playlist models to a QAbstractListModel subclass to allow the use of our SortFilterProxyModel.

  • I signed the CLA as username:
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@juli27, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: eadc4d5d-98ca-4351-9fea-5536f103f1b4

📥 Commits

Reviewing files that changed from the base of the PR and between d9878b9 and 4833259.

📒 Files selected for processing (7)
  • framework/learn/qml/Muse/Learn/CMakeLists.txt
  • framework/learn/qml/Muse/Learn/LearnPage.qml
  • framework/learn/qml/Muse/Learn/internal/Playlist.qml
  • framework/learn/qml/Muse/Learn/internal/playlistmodel.cpp
  • framework/learn/qml/Muse/Learn/internal/playlistmodel.h
  • framework/learn/qml/Muse/Learn/learnpagemodel.cpp
  • framework/learn/qml/Muse/Learn/learnpagemodel.h
📝 Walkthrough

Walkthrough

The change adds a Qt playlist list model with playlist roles and duration formatting. LearnPageModel now exposes dedicated models for started and advanced playlists and updates them from the learn service. LearnPage.qml applies fuzzy filtering and score-based sorting. Playlist delegates use bound model and index properties for navigation, metadata, scrolling, and URL launching.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding fuzzy search to the learn page.
Description check ✅ Passed The description explains the implementation, references the related issue, and completes the required checklist except for the test item.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@framework/learn/qml/Muse/Learn/internal/playlistmodel.cpp`:
- Around line 48-50: Update PlaylistModel::rowCount to return zero when the
supplied parent QModelIndex is valid, while preserving m_playlist.size() for the
invalid root index used by this flat list model.

In `@framework/learn/qml/Muse/Learn/LearnPage.qml`:
- Around line 204-222: Update the LearnPage playlist flow around the
SortFilterProxyModel to pass whether a search is active into Playlist.qml, then
handle the zero-row state separately from load failure. When an active fuzzy
search has no matches, display a dedicated no-results message; preserve the
existing “unable to load these videos” message for genuine playlist loading
failures.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ea3f57e1-6b74-42e3-8de8-02a6d6206ee8

📥 Commits

Reviewing files that changed from the base of the PR and between d9878b9 and 5ff1a47.

📒 Files selected for processing (7)
  • framework/learn/qml/Muse/Learn/CMakeLists.txt
  • framework/learn/qml/Muse/Learn/LearnPage.qml
  • framework/learn/qml/Muse/Learn/internal/Playlist.qml
  • framework/learn/qml/Muse/Learn/internal/playlistmodel.cpp
  • framework/learn/qml/Muse/Learn/internal/playlistmodel.h
  • framework/learn/qml/Muse/Learn/learnpagemodel.cpp
  • framework/learn/qml/Muse/Learn/learnpagemodel.h

Comment thread framework/learn/qml/Muse/Learn/internal/playlistmodel.cpp Outdated
Comment thread framework/learn/qml/Muse/Learn/LearnPage.qml
Refactors the playlist models to a QAbstractListModel subclass to allow
the use of our SortFilterProxyModel.
@juli27
juli27 force-pushed the addFuzzySearchLearnPage branch from 5ff1a47 to 4833259 Compare August 5, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant