Automation: various fixes

[RomanPudashkin]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e9ad5dce-a6b5-4c23-bd72-2cfba8092345

📥 Commits

Reviewing files that changed from the base of the PR and between 4dd1e6d and ec8f3cd.

📒 Files selected for processing (1)

• src/notationscene/qml/MuseScore/NotationScene/notationautomationcontroller.cpp

🚧 Files skipped from review as they are similar to previous changes (1)

• src/notationscene/qml/MuseScore/NotationScene/notationautomationcontroller.cpp

---

📝 Walkthrough

Walkthrough

The changes add AutomationData::dump() for textual curve and point inspection. They correct negative insertTime range handling and update related tests. NotationAutomation now receives an injected undo stack for point-edit transactions. The notation automation controller now merges score and automation changes, schedules asynchronous processing, and rebuilds or refreshes affected notation regions based on structural status and boundaries.

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided, so the issue reference, change summary, checklist, and testing information are missing.	Add the required description sections, including the issue reference, motivation, completed checklist items, and test or validation details.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title relates to automation changes but is too broad and does not identify the main fixes.	Replace the title with a specific summary of the primary automation fixes, such as undo-stack injection and deferred score-change processing.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@src/notationscene/qml/MuseScore/NotationScene/notationautomationcontroller.cpp`:
- Around line 698-704: Update
NotationAutomationController::processPendingChanges() so automation-only
notifications are processed instead of returning when
m_pendingScoreState.hasChanges is false. Return only when both
m_pendingScoreState and m_pendingChanges are empty, and ensure the pending
automation state is consumed and handled in the existing processing flow.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1d1cf5a5-50b4-40ea-aa34-21c33492d257

📥 Commits

Reviewing files that changed from the base of the PR and between 106e63b and 340031a.

📒 Files selected for processing (10)

• src/engraving/automation/automationdata.cpp
• src/engraving/automation/automationdata.h
• src/engraving/automation/internal/scoreautomationcontroller.cpp
• src/engraving/automation/internal/scoreautomationcontroller.h
• src/engraving/tests/automation/scoreautomationcontroller_tests.cpp
• src/notation/internal/masternotation.cpp
• src/notation/internal/notationautomation.cpp
• src/notation/internal/notationautomation.h
• src/notationscene/qml/MuseScore/NotationScene/notationautomationcontroller.cpp
• src/notationscene/qml/MuseScore/NotationScene/notationautomationcontroller.h

💤 Files with no reviewable changes (1)

• src/engraving/automation/internal/scoreautomationcontroller.h