Skip to content

Linux file picker fix - #34484

Open
embarc-gabriel wants to merge 2 commits into
musescore:mainfrom
embarc-gabriel:linux-file-picker-fix
Open

Linux file picker fix#34484
embarc-gabriel wants to merge 2 commits into
musescore:mainfrom
embarc-gabriel:linux-file-picker-fix

Conversation

@embarc-gabriel

Copy link
Copy Markdown
Contributor

Resolves: audacity/audacity#8166

Branch to test fixes on musescore/muse_framework#199

  • I signed the CLA as username:
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 70ad9f96-29a1-45f3-a717-e5b707dd87cc

📥 Commits

Reviewing files that changed from the base of the PR and between f4cdc6b and 4e71c99.

📒 Files selected for processing (3)
  • muse
  • src/project/internal/opensaveprojectscenario.cpp
  • src/project/internal/projectactionscontroller.cpp
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/project/internal/projectactionscontroller.cpp
  • src/project/internal/opensaveprojectscenario.cpp

📝 Walkthrough

Walkthrough

The muse submodule reference now points to commit eb6dddd5e05aec19ee1789708c60fda6fdad7a34. Project save and open dialogs now use [experimental] in relevant file-format labels. File extensions and supported formats remain unchanged.

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The seven label changes from parentheses to brackets do not address the linked issue's .txt preset filter and appear unrelated. Remove the unrelated format-label changes or document their required relationship to issue #8166.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check ❓ Inconclusive The main fix is hidden in the updated muse submodule, so the provided diff does not confirm that Linux preset filters now include .txt. Provide the submodule diff or test evidence showing that importing AU4 presets exposes .txt files in the native Linux file picker.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the primary change: a Linux native file picker fix.
Description check ✅ Passed The description links issue #8166, records testing context, and completes the required checklist except the optional test item.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@embarc-gabriel
embarc-gabriel force-pushed the linux-file-picker-fix branch from dad0dd4 to 2ce7744 Compare August 6, 2026 12:35
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@embarc-gabriel
embarc-gabriel force-pushed the linux-file-picker-fix branch from 2ce7744 to 4e71c99 Compare August 6, 2026 12:53
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@DmitryArefiev DmitryArefiev self-assigned this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Native Ubuntu File Picker Does Not Show Exported Presets

3 participants