Skip to content

Fix guitar bend/dive overlap with vibrato lines - #34482

Open
ajuncosa wants to merge 3 commits into
musescore:4.7from
ajuncosa:guitar-dives
Open

Fix guitar bend/dive overlap with vibrato lines#34482
ajuncosa wants to merge 3 commits into
musescore:4.7from
ajuncosa:guitar-dives

Conversation

@ajuncosa

@ajuncosa ajuncosa commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Resolves: #34422

In this PR:

  • Revert 90c0309 to ensure that vibrato lines do not ignore bends in skyline
  • Fix bends/dives that cross a system break: previously such a bend was only laid out when the end note's system was laid out, so it never made it into the start system's skyline
    • Now, the start system collects its own forward bend/dive too (in systemlayout.cpp),
    • the null system2 early return (in guitarbendlayout.cpp) is relaxed, so adaptations have been made around this, and
    • the open-ended BEGIN segment from the 1st system stops reading geometry from a note on a system that may not exist yet (in guitardivelayout.cpp).

@ajuncosa ajuncosa added the vtests This PR produces approved changes to vtest results label Aug 7, 2026
@ajuncosa
ajuncosa marked this pull request as ready for review August 7, 2026 08:40
@ajuncosa ajuncosa linked an issue Aug 7, 2026 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vtests This PR produces approved changes to vtest results

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vibrato lines overlap with dive with specific bends&dives style

3 participants