Conversation
Signed-off-by: Arthit Suriyawongkul <[email protected]>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Manual zero buckets can still crash autotuning, and the regression test may not reliably exercise the failing path.
Review effort: Lite
Findings: 1
What changed in this PR
This PR preserves manually configured buckets during Python autotuning and adds regression coverage. Non-positive buckets can still cause modulo-by-zero crashes, and the test depends on a timing-sensitive trial.
Changes:
- Retains user-specified buckets during autotuning.
- Adds regression coverage for manual bucket autotuning.
- Requires validation or substitution for non-positive buckets and deterministic trial coverage.
| File | Summary |
|---|---|
python/fasttext_module/fasttext/FastText.py |
Preserves manual bucket configuration during autotuning. |
python/fasttext_module/fasttext/tests/test_autotune_bucket.py |
Adds regression coverage for autotune bucket handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Contributor
Author
|
Fixed as suggested in review. A manual bucket=0 under autotune now means no n-gram trials (no wordNgrams/minn sampling, maxn=0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.