fix: use np.asarray in meter curves for NumPy 2 - #22
Merged
Merged
Conversation
- Replace np.array(..., copy=False), which raises on NumPy 2, with np.asarray (in score_vs_true and precision_recall_curve) - Add a regression test Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates meter curve conversions for NumPy 2 compatibility and adds regression coverage.
Changes:
- Replaces
np.array(..., copy=False)withnp.asarray. - Adds tests for both meter curve methods.
| File | Description |
|---|---|
python/fasttext_module/fasttext/tests/test_meter.py |
Adds regression tests for meter curve arrays. |
python/fasttext_module/fasttext/FastText.py |
Uses NumPy 2-compatible array conversion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
munlicode
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
np.array(..., copy=False), which raises on NumPy 2, withnp.asarray(in score_vs_true and precision_recall_curve functions)