Conversation
bact
commented
Sep 28, 2026
bact
commented
Contributor
- Raise ValueError instead of segfaulting on a second quantize()
- Reset the quantized flag in loadModel and setMatrices
- Add regression tests
Signed-off-by: Arthit Suriyawongkul <[email protected]>
bact
marked this pull request as draft
September 28, 2026 10:59
Signed-off-by: Arthit Suriyawongkul <[email protected]>
bact
marked this pull request as ready for review
October 4, 2026 18:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.