Repository navigation
fix: raise ValueError in get_subword_id when bucket == 0 - #15
Merged
Merged
Conversation
Default supervised models have bucket=0, so getSubwordId and getSubwordVector did `hash % 0`: SIGFPE on x86_64, out-of-range id on arm64. This fix will throw std::invalid_argument (ValueError in Python) instead. Signed-off-by: Arthit Suriyawongkul <[email protected]>
Contributor
Author
|
Note that the test currently uses threads = 10 to avoid NaN bug. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The fix is covered for the reported case, and remaining feedback is limited to minor nits.
Review effort: Lite
Findings: None
What changed in this PR
Fixes subword handling for models with no buckets by raising ValueError instead of performing invalid modulo operations.
Changes:
- Validates bucket counts in subword ID and vector methods.
- Adds a Python regression test for zero-bucket models.
| File | Summary |
|---|---|
src/fasttext.cc |
Adds guards for non-positive buckets. Minor nits note untested getSubwordVector coverage and misleading negative-bucket diagnostics. |
python/fasttext_module/fasttext/tests/test_script.py |
Verifies get_subword_id raises ValueError. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default supervised models have bucket=0, so getSubwordId and getSubwordVector did
hash % 0: SIGFPE on x86_64, out-of-range id on arm64.This fix will throw std::invalid_argument (ValueError in Python) instead.