Phase 26 F3: remove fabricated data — kubecost/asean/audit fail-closed - #73
Merged
Merged
Conversation
…asean-sw-service, audit-service — fail-closed - kubecost-svc: all cost figures now proxied from the real Kubecost Allocation API (KUBECOST_URL required, log.Fatal otherwise); upstream failure -> 503 with honest error; removed mock tenant registry, rand-based cost generators and all hardcoded figures - asean-sw-service: pgx/v5 persistence to existing asean_sw_messages table (DATABASE_URL required, fail-closed startup, ping); removed simulated ACKs and in-memory store; connection tests are real HTTP probes with measured latency; dispatch failure -> 502, message persisted as failed - audit-service: pgx/v5 persistence to existing post_clearance_audits table (DATABASE_URL required, fail-closed startup, ping); selected audits inserted as real rows; discrepancy/penalty update existing audits and 404 when absent; stats include real DB counts; /health does SELECT 1 - No seed rows, no fabricated fallbacks; HTTP route paths and JSON shapes preserved; no gRPC added; drizzle schema and migrations untouched
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
G5b remediation. kubecost-svc proxies the real Kubecost Allocation API (KUBECOST_URL required, 503 fail-closed on upstream failure; all hardcoded cost figures removed). asean-sw-service persists to asean_sw_messages via pgx/v5 (DATABASE_URL fail-closed; simulated ACKs and ping latency removed — real gateway dispatch/probes). audit-service persists to post_clearance_audits via pgx/v5 (DATABASE_URL fail-closed; discrepancy/penalty 404 when no audit row exists). Route paths + JSON shapes preserved; no seeds; no schema/migration changes;
go build ./...clean-cache exit 0 for all three services.