refactor: make heap projections explicit - #606
Draft
baszalmstra wants to merge 2 commits into
Draft
Conversation
baszalmstra
marked this pull request as draft
September 6, 2026 13:28
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## bas/typed-codegen-values #606 +/- ##
============================================================
- Coverage 87.32% 87.14% -0.19%
============================================================
Files 254 254
Lines 26933 26887 -46
============================================================
- Hits 23520 23430 -90
- Misses 3413 3457 +44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
baszalmstra
force-pushed
the
bas/place-projections
branch
2 times, most recently
from
September 6, 2026 14:27
674c577 to
36492b2
Compare
baszalmstra
force-pushed
the
bas/place-projections
branch
from
September 6, 2026 15:29
36492b2 to
c65a8f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Heap references and arrays recovered their pointee types by inspecting LLVM pointer element types. Opaque pointers remove that information, and unchecked wrapper construction let the wrong pointer depth travel until a later load or GEP failed.
What
PlaceValues from heap, field, and array projectionsget_element_typecalls from codegenTesting
pixi run checkwithRUSTFLAGS=-Dwarningspixi run cargo test -p mun_codegen --libpixi run cargo test -p mun_codegen --test abi