chore(package): build before packaging so a stale bundle cannot ship - #431
Merged
Merged
Conversation
pnpm package only ran vsce + the vsix audit, and the audit checks presence, not freshness, so a stale dist/ produced a passing .vsix (and a clean checkout failed outright). Chain pnpm build in front. CI, publish and deploy call vsce directly after their own build, so they are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm packageran onlyvsce packageand the vsix audit. The audit checks that the payload is present, not that it is fresh, so a staledist/produced a passing.vsix, and on a clean checkout the command failed outright. The script now runspnpm buildfirst.Changes
package.json:packageis nowpnpm build && <previous command>.test/build/package-script-audits-vsix.test.ts: pin that the script starts with the build.README.md,CONTRIBUTING.md: comments next topnpm packagenow say it builds.CI, publish and
scripts/deploy.shbuild once and callvscedirectly, so they are unaffected.vscode:prepublishis deliberately not used: vsce always runs it, which would make those paths build again.Test Plan
package.jsonchange and passes with it.dist/extension.cjsplus a modified source file:pnpm packageexits 0 and the packagedextension.cjscontains the new source string and not the stale marker.pnpm packageexits 2 withTS2322and no.vsixis produced.