Repository navigation
feat(check-fork): 同步须保留的本地决定改由正向守卫检查 - #14
Merged
Merged
Conversation
ADAPTATION 记录的本地决定此前只靠阅读守护:守卫只拦 Cursor 黑名单, 上游整文件覆盖会静默抹掉 replay、显式授权、fast mode、--once 等本地措辞。 新增与 DENYLIST 平行的 REQUIRED 表:每条规则给出文件、可选锚点句和 ADAPTATION 小节,缺文件或锚点即报错,引用的小节不存在也报错。 validateT3Contract 的四个锚点并入该表。植入测试逐条删掉锚点 (有上游原文时换成上游措辞),确认只有对应规则报告;表中新增规则 而无植入用例时测试失败。 Co-Authored-By: Claude Opus 5.5 <[email protected]>
ADAPTATION 中约 700 词的验收细则与脚本及其测试重复,每次 fix(e2e) 都要双写。细则移到脚本 docstring,与执行它的代码同处;ADAPTATION 只保留运行时机、判定原则与超时约定。--help 只显示首行摘要,并在 epilog 指向 docstring。 Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
分支保护已对 main 生效(含管理员),三个必需检查只认 GitHub Actions。 检查名由 job name 和 matrix 的 os/node/python 拼成,改版本或 job 名的 PR 须同时更新保护规则,否则一直等待旧检查名。补充 PUT 更新(整体替换, 须带全部设置)、回读与 DELETE 撤销命令。 Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ADAPTATION 里"同步时必须保留"的本地决定原本只靠人去读。check-fork 只拦 Cursor 黑名单,所以上游整文件覆盖会悄悄抹掉 replay、显式授权、fast mode、
--once这类本地措辞,任何检查都不会失败。另外,宿主 e2e 的验收细则(约 700 词)在 ADAPTATION、脚本和测试里各写一遍,每次fix(e2e)都要改两处。What changed
scripts/check-fork.mjs新增REQUIRED表,和DENYLIST并列,共 20 条。每条规则写明文件、可选的锚点句和对应的 ADAPTATION 小节。文件或锚点缺失时报错;规则引用的小节不存在也报错。validateT3Contract的 4 个锚点并入了这张表。scripts/pstack-host-e2e.py的模块 docstring,ADAPTATION 只保留何时运行、判定原则和超时约定。--help只显示首行摘要。AGENTS.md,写明门禁、上游同步规则、缓存不可编辑,以及安装刷新命令在哪里。docs/ci.md的 GitHub checks 小节写明:main 的分支保护已开启(对管理员也生效);三个必需检查名由 job name 和 matrix 值拼成,改版本或 job 名时须同时更新保护规则。另附 PUT 更新、回读和 DELETE 撤销命令。Scope
--once"这一句:上游文件里的本地改动,和watch-pr-once是同一个决定。merge-gates.test.ts及 READY 规则)、orch lock 修复(orch/lock.ts、lock.test.ts)、github-remote.ts:目前只有 Bun 测试守着,整目录覆盖时测试文件会跟着一起消失。bin/xagent和bin/xagent-pi-guard.ts:ADAPTATION 里和 allowlist 写在同一句。Tradeoffs
REQUIRED反推,这样能独立核对规则指向的是不是正确的文件。Blast Radius
只影响
check.sh runtime的静态检查和文档,不改任何 skill、playbook 或运行时行为。以后的上游同步如果删改了受守卫的句子,这项检查会失败。Verification
bash scripts/check.sh runtime(macOS,PATH 加入 coreutils gnubin),HEAD09f2ac3check-fork.mjs和check-fork.test.mjsreplay-runs-first的锚点放宽成/replay/;关闭小节校验skills/xagentgh api .../branches/main/protection的回读对比(只读)bash scripts/check.sh build🤖 Generated with Claude Code