feat(cli): remote folders and telemetry consent; fix spaces in remote folder names

[mthines]

Summary

Three changes, plus the review loop's follow-up fixes.

fix(settings): keep spaces in remote folder names (87a4ee5, e07777e, 7ee2ce4)

Reported on Reddit: a remote folder named My Folder showed up as Folder in the profile editor's folder chooser. The chooser parsed rclone lsd output, which is a whitespace-padded column, by splitting on spaces. Everything before the last space was lost. This is not a regression; the bug has been there since the chooser was added (792bfe8).

• One listing path: all three listing sites now use rclone lsf --dirs-only, which prints one name/ per line verbatim. They share folderListingArguments and parseDirectoryListing. The three sites are the setup wizard (RcloneConfigService.listFolders), the folder chooser (ProfileDetailView.loadRemoteFolders) and the "Sync Only These Folders" browser (RemoteFolderBrowserSheet). Leading, trailing and doubled spaces, and non-ASCII names, survive. The wizard's list is now sorted.
• No more hang on large output: stdout and stderr are drained at the same time by one helper, RcloneConfigService.drainPipes. Reading one pipe to the end first deadlocks once the other fills its ~64 KB buffer. The CLI's own rclone runner now uses the same helper. stderr is kept apart from the listing, so an rclone warning can't show up as a folder.

feat(cli): synctray remote folders <remote>[:path] [--json] (fb68598)

Lists a remote's folders exactly as the app shows them, with the same arguments (including the remote's no_check_certificate) and the same parser. It needs no profile. --json makes leading and trailing spaces visible.

feat(cli): ask for usage-data consent once and share it with the app (1120507, 612b050, 0bf1782)

• One-time question: the CLI asks once whether to share usage data, using the app banner's own copy (Share usage data? [y/N], default No). It asks only on an interactive run of a command that parses, and only while the question is unanswered. The question counts as answered once the user has answered it in the app's banner or setup wizard, or in the CLI, for the current consent version.
  • Known gap, unchanged by this PR: flipping the Settings toggle doesn't mark the question answered. Someone who only used that toggle to keep usage data off is asked once in the CLI.
• Never blocks scripts or agents: stdin and stderr must both be a TTY and CI must be unset; help and telemetry never ask.
• synctray telemetry [status|on|off] [--json]: the same telemetryEnabled setting the app uses. It also writes that one key to settings.json, so a running app applies the change live, and it never touches launchAtLogin.
• Telemetry source: CLI telemetry carries the resource attribute synctray.process.kind=cli, and the app sends app. service.name stays synctray, so existing queries keep working.
• Quieter stderr: exporter diagnostics are silent in CLI mode.

Not addressed here

The include-folder browser now shows folder names with leading or trailing spaces exactly as they are. SyncProfile.normalizedSyncIncludeFolders still trims them on save, though, so such a folder can't be selected for "Sync Only These Folders". The trimming predates this PR.

Test plan

• SyncTray --self-test: 123 checks pass. Each check below was confirmed to fail against the broken code.
  • AC-RF1: parser checks, a real child process writing 300 KB to each pipe, and source pins on all four call sites.
  • AC-CLI12: remote folders.
  • AC-CLI13: when the question is asked (including a typo staying silent), default No, telemetry parse/output, and the settings.json key-only update.
• Real rclone against folders named My Folder, My songs, trailing space and Café: listed verbatim as text and as --json.
• Real binary: telemetry status/on/off; piped runs never ask; a bad argument exits 64; settings.json round-trips byte-identical.
• CI green; scripts/check-schema-in-sync.sh passes.

[dash0-dev]

Darkplane auto-approval is enabled for this repository (mode: Auto-approve).

Trigger an evaluation for this pull request when it is ready:

[mthines]

✅ No issues found

No new commits since the last review at a1831f8; the edited description now covers the follow-up fixes, all three prior threads are resolved, and CI is green.

Progress: open review threads 1 → 2 → 0 → 0 across the last 4 reviews

Review details

Gate	Status	Details
Description vs. code	✅	Description now covers all three changes and the review-loop follow-ups (parse gate, drainPipes)
Prior review feedback	✅	Earlier review comments are resolved.
Documentation	✅	Description, CLAUDE.md and telemetry.md document the new commands, consent flow and drainPipes
Self-review signals	✅	No debug logs, leftover TODOs, or unreviewed stubs.
Code review	✅	The multi-lens review found no blocking issues.

Found

Quality — produced 0 → posted inline 0 · cleared 0 · carried forward 0 · deferred 0 · below-bar 0

Run

incremental · 0 lines in delta · tier deep · depth checkout
Memories — skipped (zero-delta fast path)

^{Nothing to report — standards (skipped), optimality (skipped), measurability (skipped), integrations (skipped), severity, 0 files skipped.}

^{pr-reviewer · commit a1831f8 · no code changes since a1831f8, gate checks only · how these findings are produced · updated Oct 9, 2026 7:28am UTC}