Skip to content

chore(aw): scope preview api telemetry by web session, not environment - #721

Merged
dash0-dev[bot] merged 1 commit into
mainfrom
chore/aw-preview-api-telemetry-scope
Oct 21, 2026
Merged

dash0-dev[bot] merged 1 commit into
mainfrom
chore/aw-preview-api-telemetry-scope

Conversation

@dash0-dev

@dash0-dev dash0-dev Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Why

.agents/aw/telemetry.yml and notes.md say a PR's web preview uses the preview Supabase project and tags its api spans deployment.environment.name=preview. On #718's preview, a list call from web session 00a41f1f23d0e335 (web events tagged preview, host lorekit-canpjnb9o-…) landed on api spans tagged production at the pre-merge service.version c4ea7ab4, so a telemetry check filtered on preview misses every api span of a preview run.

What changed

  • telemetry.yml: the preview comment says preview api spans arrive as production and are scoped by dash0.trace.origin.web.session.id.
  • notes.md: a new bullet gives the join (preview-host web events → session.id → api spans) and says what preview on api actually marks (the preview Supabase project: main's staging deploy and /preview).
  • notes.md: page.url.domain can be the pr-<n> alias or the immutable lorekit-<hash>-… host.

How to verify

  • yq '.environments.preview' .agents/aw/telemetry.yml still prints {dataset: default, namespace: lorekit}; only comments changed there.
  • Compare web-preview-deploy.yml ("No Supabase override") with preview.yml (supabase-project-ref) and deploy.yml (DEPLOYMENT_ENVIRONMENT="preview").

Notes for reviewers

No user-facing docs or llms.txt change: .agents/aw/ is agent verification config, not a product surface.

A PR's web preview calls the production api, so its api spans carry
deployment.environment.name=production. Correct telemetry.yml and notes.md
to scope them by dash0.trace.origin.web.session.id from the preview host's
web events, and say what deployment.environment.name=preview marks instead.

Co-authored-by: dash0-dev[bot] <257284812+dash0-dev[bot]@users.noreply.github.com>
@dash0-dev

dash0-dev Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

✅ No issues found

Comment/notes-only fix to the .agents/aw preview telemetry guidance. Each factual claim checked: the workflows match, and live Dash0 data shows preview api spans tagged production with a working web-session join. No findings.

Review details
Gate Details
Description vs. code ✅ Body lists exactly the three edits the diff makes: the telemetry.yml comment and two notes.md bullets.
Prior review feedback ✅ Earlier review comments are resolved.
Documentation ✅ Body gives the observed cause (#718 preview), the edits, and verify steps; the diff is itself the doc.
Self-review signals ✅ No debug logs, leftover TODOs, or unreviewed stubs.
Code review ✅ The multi-lens review found no blocking issues.
Run Details
Mode full · 14 lines in delta · tier deep · depth checkout
Anomaly ⚠️ no sub-agent dispatch available — the intent finder ran in-context with the other finders at effective thoroughness 0.95, instead of as its own sub-agent — 2 prepare-time anomalies (reviewer identity unknown (no --reviewer-login / PR_REVIEWER_LOGIN; /user 401s here) — relation defaulted to cross, +1 more)
Checked 2 of 2 changed files read · 7 possible issues → 0 confirmed → 0 posted
Found produced 7 → posted inline 0 · cleared 0 · carried forward 0 · deferred 0 · below-bar 0
Dropped 4 below-bar
Standards ran — CLAUDE.md (49 bullets) against 2 files; 0 findings
Integrations not activated — the diff touches no manifest or lockfile
Memories no relevance rules or lessons consulted

Nothing to report — measurability (skipped), severity, reach (impact graph found no consumer or importer), 0 files skipped.

pr-reviewer · commit b52cbc5 · full review · how these findings are produced · updated Oct 21, 2026 7:42pm UTC

@dash0-dev
dash0-dev Bot marked this pull request as ready for review October 21, 2026 19:44
@dash0-dev
dash0-dev Bot requested a review from mthines as a code owner October 21, 2026 19:44
@dash0-dev
dash0-dev Bot merged commit bf73883 into main Oct 21, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant