Repository navigation
chore(aw): scope preview api telemetry by web session, not environment - #721
Merged
Merged
Conversation
A PR's web preview calls the production api, so its api spans carry deployment.environment.name=production. Correct telemetry.yml and notes.md to scope them by dash0.trace.origin.web.session.id from the preview host's web events, and say what deployment.environment.name=preview marks instead. Co-authored-by: dash0-dev[bot] <257284812+dash0-dev[bot]@users.noreply.github.com>
Contributor
Author
✅ No issues foundComment/notes-only fix to the .agents/aw preview telemetry guidance. Each factual claim checked: the workflows match, and live Dash0 data shows preview api spans tagged production with a working web-session join. No findings. Review details
Nothing to report — measurability (skipped), severity, reach (impact graph found no consumer or importer), 0 files skipped.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
.agents/aw/telemetry.ymlandnotes.mdsay a PR's web preview uses the preview Supabase project and tags its api spansdeployment.environment.name=preview. On #718's preview, a list call from web session00a41f1f23d0e335(web events taggedpreview, hostlorekit-canpjnb9o-…) landed on api spans taggedproductionat the pre-mergeservice.versionc4ea7ab4, so a telemetry check filtered onpreviewmisses every api span of a preview run.What changed
telemetry.yml: thepreviewcomment says preview api spans arrive asproductionand are scoped bydash0.trace.origin.web.session.id.notes.md: a new bullet gives the join (preview-host web events →session.id→ api spans) and says whatpreviewon api actually marks (the preview Supabase project: main's staging deploy and/preview).notes.md:page.url.domaincan be thepr-<n>alias or the immutablelorekit-<hash>-…host.How to verify
yq '.environments.preview' .agents/aw/telemetry.ymlstill prints{dataset: default, namespace: lorekit}; only comments changed there.web-preview-deploy.yml("No Supabase override") withpreview.yml(supabase-project-ref) anddeploy.yml(DEPLOYMENT_ENVIRONMENT="preview").Notes for reviewers
No user-facing docs or
llms.txtchange:.agents/aw/is agent verification config, not a product surface.