Repository navigation
chore/Python-version-pin · L-261023-540990 - #104
Merged
Merged
Conversation
…ell's version .python-version names 3.13, the version the Makefile defaulted to. The Makefile reads it and exports the chosen version as UV_PYTHON, so PYTHON_VERSION or UV_PYTHON still select another one and every uv command, uv sync included, keeps .venv on it. The lint and test matrices set UV_PYTHON for the whole job instead of prefixing one command, and end by asserting that .venv ran the version the job names. docs/development.md says where the interpreter is pinned and how to try another. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01TuqArJByf4EdN7khSDRiPe
Nothing in the repository reads TEST_PROFILE, so the prefix on lint-check.yml's make install did nothing. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01TuqArJByf4EdN7khSDRiPe
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The development interpreter is now pinned to 3.13 in .python-version, and the Makefile exports it as UV_PYTHON so every uv command uses it unless PYTHON_VERSION or UV_PYTHON asks for another. Each matrix job sets UV_PYTHON from its matrix version for the whole job and ends by asserting its interpreter, so a matrix can no longer silently test only the pinned version; this is the pilot of that pattern for the workspace.
Closes L-261023-540990
🤖 Generated with Claude Code
https://claude.ai/code/session_01TuqArJByf4EdN7khSDRiPe
Summary by cubic
Pins the development interpreter to 3.13 in
.python-versionand makes CI prove each matrix job actually runs the version it names..python-versionand exports it asUV_PYTHON, so every uv command agrees on one interpreter unlessPYTHON_VERSIONorUV_PYTHONasks for another.UV_PYTHONfor the whole job and assert the interpreter matches, so a matrix can no longer silently test only the pinned version.PYTHON_VERSION=<version> make installstill builds.venvon anotherrequires-python-supported version.Written for commit fa3180d. Summary will update on new commits.