Repository navigation
Keep Luminare window traffic lights circular - #32
Merged
Merged
Conversation
mrkai77
force-pushed
the
fix/traffic-lights-shape
branch
from
August 29, 2026 08:06
284c9b3 to
3cb7766
Compare
mrkai77
force-pushed
the
fix/traffic-lights-shape
branch
2 times, most recently
from
August 29, 2026 08:47
3085375 to
fb2ef83
Compare
mrkai77
force-pushed
the
fix/traffic-lights-shape
branch
from
August 29, 2026 08:48
fb2ef83 to
9404a79
Compare
mrkai77
approved these changes
Aug 29, 2026
mrkai77
left a comment
mrkai77
left a comment
Owner
There was a problem hiding this comment.
Sorry for the delay! Modified your approach of making the buttons perfect circles, and it seems to work better now. Tested on macOS 14, macOS 26 and also macOS 27 beta 7, and they all work now :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects the AppKit traffic-light aspect ratio without triggering recursive window layout. The rendered controls now remain circular while preserving native positioning and tracking behavior.
Before:
Now:
