Repository navigation
refactor(http3): expose connect_udp_set_datagram_max_age methods - #4334
Open
aochagavia wants to merge 1 commit into
Open
aochagavia wants to merge 1 commit into
aochagavia wants to merge 1 commit into
Conversation
aochagavia
requested review from
KershawChang,
larseggert,
martinthomson,
mxinden and
omansfeld
as code owners
November 11, 2026 16:12
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4334 +/- ##
==========================================
- Coverage 97.12% 96.60% -0.52%
==========================================
Files 113 118 +5
Lines 43301 43709 +408
Branches 43301 43709 +408
==========================================
+ Hits 42054 42224 +170
- Misses 1231 1464 +233
- Partials 16 21 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mxinden
reviewed
Nov 13, 2026
mxinden
left a comment
mxinden
left a comment
Member
There was a problem hiding this comment.
Instead of making the max-age mechanism configurable, I would prefer us disabling it for all connect-udp sessions for now. I don't see how enabling this mechanism will lead to any meaningful performance improvement in the case of connect-udp. We can later on revisit that decision.
Objections @aochagavia?
In the presence of backpressure, the inner connect_udp connection may queue outbound datagrams for a long time. We now disable datagram expiration, because otherwise we may silently drop datagrams.
aochagavia
force-pushed
the
refactor-max-age
branch
from
November 13, 2026 13:45
a4b8dbb to
1f2880f
Compare
Collaborator
Author
|
Makes lots of sense, thanks! Just pushed an update. |
Contributor
Merging this PR will degrade performance by 0.27%1 warning
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
|
Contributor
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
|
Contributor
Client/server transfer resultsPerformance differences relative to d95c6bb. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Table above only shows statistically significant changes. See all results below. All resultsTransfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the presence of backpressure, the inner connect_udp connection may queue outbound datagrams for a long time. We need a way to set an appropriate datagram max age, because otherwise we may silently drop datagrams.