Repository navigation
Bug 2079453 - Upgrade devbridge-autocomplete to 2.0.1 and fix autocomplete dropdown reopening after the field loses focus - #2775
Conversation
…plete dropdown reopening after the field loses focus
There was a problem hiding this comment.
🔵 Needs a closer look
The major dependency upgrade needs browser-level compatibility validation across autocomplete consumers.
0 open findings
What changed in this PR
Upgrades autocomplete to 2.0.1 and adapts the user and product/component widgets to prevent delayed results from reopening dropdowns after focus is lost.
Changes:
- Updates the dependency and lockfile.
- Defers focus checks until after suggestions render.
- Adds regression tests for focused and blurred inputs.
| File | Description |
|---|---|
| qa/t/2_test_autocomplete.t | Tests delayed lookups with and without focus. |
| package.json | Upgrades devbridge-autocomplete to 2.0.1. |
| package-lock.json | Locks the upgrade and updates DOMPurify. |
| js/field.js | Defers hiding unfocused user suggestions. |
| extensions/ProdCompSearch/web/js/prod_comp_search.js | Defers hiding unfocused product/component suggestions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -11,7 +11,7 @@ | |||
| "//": "The generated files are not committed; the Docker assets stage builds them from this lockfile. Dependabot proposes upgrades and CI tests them with no regeneration step needed; treat majors (jquery 4.x, mermaid 11.x, devbridge 2.x) as manual, tested reviews. A bump now moves a library's stylesheet along with its script, so review upgrades for visual changes too. bpopup is not published to npm and remains vendored under js/jquery/plugins/bPopup/.", | |||
There was a problem hiding this comment.
The treat majors (..., devbridge 2.x) as manual is out of date now ;)
+ same wordings in README.rst (line 343) and .github/dependabot.yml (line 26)
Xzzz
left a comment
Xzzz
left a comment
There was a problem hiding this comment.
Changes are safe, lgtm. Just one small note inline about the stale "2.x" mentions.
kyoshino
left a comment
kyoshino
left a comment
There was a problem hiding this comment.
I can’t reproduce the issue with the prod comp search. I’m not sure if the change to prod_comp_search.js is necessary, but I don’t think it will cause any problems 🙂
Co-authored-by: Kohei Yoshino <[email protected]>
Co-authored-by: Kohei Yoshino <[email protected]>
No description provided.