Repository navigation
Fix issue #26 with with space in path - #27
Merged
Merged
Conversation
This commit introduces a new function, _run_osrm_cmd, to streamline the execution of OSRM CLI commands. It addresses an issue with path arguments containing spaces by creating temporary symlinks, ensuring compatibility with OSRM's command-line interface. The contract, customize, extract, and partition functions have been updated to utilize this new method.
This commit introduces a new test suite to validate the functionality of OSRM commands when file paths contain spaces. It includes tests for extraction, partitioning, customization, and routing, ensuring that the recent changes to handle spaces in paths are functioning correctly. Temporary directories are used to simulate paths with spaces during testing.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…pdate cleanup to force removal of temporary directories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
causes #26