Repository navigation
refactor(NODE-7872): simplify check for null in findNull - #940
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The equivalent simplification preserves null detection and out-of-bounds handling for Uint8Array.
Review effort: Balanced
Findings: None
What changed in this PR
Simplifies null-terminator scanning in the on-demand BSON parser without changing behavior.
Changes:
- Replaces the explicit bounds/value condition with a concise byte truthiness check.
| File | Description |
|---|---|
src/parser/on_demand/parse_to_elements.ts |
Simplifies findNull scanning logic. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
johnmtll
changed the title
Contributor
|
Thanks @nbbeeken! This has been assigned to https://jira.mongodb.org/browse/NODE-7872. Looks good to me. Will be addressed in the next triage session. 🙇 |
dariakp
added
the
tracked-in-jira
seanrmilligan
added
the
Primary Review
seanrmilligan
previously approved these changes
Oct 14, 2026
seanrmilligan
added
Team Review
seanrmilligan
previously approved these changes
Oct 14, 2026
tadjik1
reviewed
Oct 14, 2026
Co-authored-by: Sergey Zelenov <[email protected]>
seanrmilligan
approved these changes
Oct 14, 2026
tadjik1
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
One less condition to check
Notes for Reviewers
What is the motivation for this change?
Less code, less problems
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript