test(runtime): dynamic lifecycle fixtures keep their controller lease through slow CI setup

[aviggiano]

Problem

model-fanout dynamic nodes stay pending until every generated attempt has evidence (packages/runtime/test/dynamic-lifecycle.test.ts) fails intermittently in the runtime-supporting lane. It failed on main at 142ba80 and on #1205:

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ 'controller-loss'
- 'dependency'

Root cause

• When the workflow is running with no active work, synchronization looks at the time since the last transition. After one controller lease (controller_lease_seconds, 30 s by default), it treats the controller as lost and parks every open node with controller-loss (workflow-control.ts, noTransitionStall).
• The dynamic fixtures' fake runner never heartbeats. The test took about 43 s on the failing runners, so by the time it synchronized, the lease had expired.
• Another test in the same file already works around this ("Keep its lease current independently of CI setup time") by pinning the sync clock.

Change

writeDynamicProject gives every dynamic-lifecycle fixture a one-hour controller lease. The test first asserts that the scaffolded config has the default controller_lease_seconds = 30 line, so a scaffold change cannot silently skip the replacement. No test in the file checks lease expiry. Test-only.

Verification

• A temporary variant of the failing test synchronized 60 s after the run's last transition, to reproduce a slow runner. On origin/main it fails with exactly the CI error (actual: 'controller-loss', expected: 'dependency'). With this change it passes.
• dynamic-lifecycle.test.ts: 19/19.
• prettier and eslint pass.

🤖 Generated with Claude Code

Confidence Score: 5/5

The PR appears safe to merge.

Summary

The PR gives dynamic-lifecycle test fixtures a one-hour controller lease so slow CI setup does not cause a non-heartbeating fake runner’s open nodes to be parked as controller losses. It also checks the scaffold default before replacing it.

_{Reviews (1) · Last reviewed commit: "test(runtime): dynamic lifecycle fixture..."}