Skip to content

Allow slow CI runners to finish runtime and CLI tests #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aviggiano merged 1 commit into from
Sep 22, 2026
Merged

Allow slow CI runners to finish runtime and CLI tests #1137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions scripts/ci/release-validation-lanes.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,39 +43,42 @@ export const RELEASE_VALIDATION_LANES = Object.freeze([
lane: "runtime-1",
description: "Node.js 24 runtime integration tests, shard 1/4",
gates: "runtime-1",
timeout_minutes: 75,
// A slow hosted runner passed 59 of shard 4's 67 tests before the old
// 75-minute cutoff. Give every shard the same bounded completion budget.
timeout_minutes: 120,
pull_request: true,
build_modal_dependencies: true
},
{
lane: "runtime-2",
description: "Node.js 24 runtime integration tests, shard 2/4",
gates: "runtime-2",
timeout_minutes: 75,
timeout_minutes: 120,
pull_request: true,
build_modal_dependencies: true
},
{
lane: "runtime-3",
description: "Node.js 24 runtime integration tests, shard 3/4",
gates: "runtime-3",
timeout_minutes: 75,
timeout_minutes: 120,
pull_request: true,
build_modal_dependencies: true
},
{
lane: "runtime-4",
description: "Node.js 24 runtime integration tests, shard 4/4",
gates: "runtime-4",
timeout_minutes: 75,
timeout_minutes: 120,
pull_request: true,
build_modal_dependencies: true
},
{
lane: "cli",
description: "CLI package tests",
gates: "cli",
timeout_minutes: 75,
// The complete local CLI suite took 76 minutes before job setup overhead.
timeout_minutes: 120,
pull_request: false,
build_release_reporter: true
},
Expand Down
9 changes: 6 additions & 3 deletions scripts/ci/release-validation-lanes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,11 @@ describe("release validation lane policy", () => {
expect([...gates].sort()).toEqual([...PULL_REQUEST_REQUIRED_GATES].sort());
});

it("gives the complete supporting runtime suite its proven shared-runner budget", () => {
const supporting = RELEASE_VALIDATION_LANES.find((lane) => lane.lane === "runtime-supporting");
expect(supporting?.timeout_minutes).toBe(120);
it("gives complete runtime and CLI suites a bounded budget beyond observed 75-minute runs", () => {
for (const name of [...PULL_REQUEST_REQUIRED_GATES, "cli"]) {
const lane = RELEASE_VALIDATION_LANES.find((candidate) => candidate.lane === name);
expect(lane?.timeout_minutes).toBe(120);
}
});

it("covers every runtime test file on pull requests", () => {
Expand Down Expand Up @@ -85,6 +87,7 @@ describe("release validation lane policy", () => {
const job = releaseValidation.slice(0, releaseValidation.indexOf("\n release-gates:"));
expect(job).not.toContain("if: github.event_name != 'pull_request'");
expect(job).toContain("fromJSON(needs.release-validation-lanes.outputs.lanes)");
expect(job).toContain("timeout-minutes: ${{ matrix.timeout_minutes }}");
});

it("requires the release validation lanes on pull requests", () => {
Expand Down
Loading