sdg(phase-11): fix the first-release no-op version bump in the Release workflow - #5
Merged
Merged
Conversation
…e workflow The live no-credential Release run (30397083855) surfaced a latent bug: when the computed release version equals package.json's version — exactly the first-release case — plain 'npm version' fails with 'Version not changed', killing the step before the publish attempt and before the instruction-bearing error message. Add --allow-same-version and group the version bump and publish under one failure handler so any failure in the sequence emits the loud setup instructions. (The retired token workflow carried the same latent bug, masked by its secret guard.) Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4, surfaced by the live no-credential Release run (30397083855): when the computed release version equals
package.json's version — exactly the first-release case (baseline 0.1.0, nothing published, releasing 0.1.0) — plainnpm versionfails withnpm error Version not changed, killing the step before the publish attempt and before the instruction-bearing::error::message.Fix:
--allow-same-versionon the bump, and the bump andnpm publishgrouped under one failure handler so any failure in the sequence emits the loud setup instructions. Verified: YAML parses, the step passesbash -n,npm version 0.1.0 --no-git-tag-version --allow-same-versionsucceeds on a 0.1.0 package, and a bump failure skips the publish while firing the handler. (The retired token workflow carried the same latent bug, masked by its secret-guard step.)🤖 Generated with Claude Code