Repository navigation
require COLUMNS, WIDTH and DIGITS in a print format - #549
Merged
Merged
Conversation
Regenerate from MODFLOW-ORG/modflow6@65278c93, which merges #3129. The DFNs now make columns, width and digits required and the format word optional, as MF6 reads them. So HEAD PRINT_FORMAT COLUMNS 10 WIDTH 11 DIGITS 4 loads (mf6/test/test060_gms_ets now passes), and a record that stops early, which MF6 now rejects, fails to parse. Codegen made a required tagged first child the record's trigger keyword, which writes its value after any other tagged fields. Only do that when no other child is tagged, so the format record keeps COLUMNS first. The Format fields are now in DFN order, columns, width, digits, format_, so its tuple form is (10, 12, 6, "GENERAL"). The new DFN commit is on develop, unlike the last one, so MAW also loses CONNECTION_STATUS and BOTTOM, which develop reverted in #3089. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accommodate MODFLOW-ORG/modflow6#3129.
COLUMNS,WIDTHandDIGITSare now required and the format word optional, as in MF6, which now rejects a partial print format instead of silently ignoring it.