Skip to content

require COLUMNS, WIDTH and DIGITS in a print format - #549

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:print-format
Nov 11, 2026
Merged

wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:print-format

Conversation

@wpbonelli

@wpbonelli wpbonelli commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Accommodate MODFLOW-ORG/modflow6#3129. COLUMNS, WIDTH and DIGITS are now required and the format word optional, as in MF6, which now rejects a partial print format instead of silently ignoring it.

Regenerate from MODFLOW-ORG/modflow6@65278c93, which merges #3129. The
DFNs now make columns, width and digits required and the format word
optional, as MF6 reads them. So HEAD PRINT_FORMAT COLUMNS 10 WIDTH 11
DIGITS 4 loads (mf6/test/test060_gms_ets now passes), and a record that
stops early, which MF6 now rejects, fails to parse.

Codegen made a required tagged first child the record's trigger keyword,
which writes its value after any other tagged fields. Only do that when
no other child is tagged, so the format record keeps COLUMNS first.

The Format fields are now in DFN order, columns, width, digits, format_,
so its tuple form is (10, 12, 6, "GENERAL").

The new DFN commit is on develop, unlike the last one, so MAW also loses
CONNECTION_STATUS and BOTTOM, which develop reverted in #3089.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@wpbonelli wpbonelli added this to the MMP milestone Nov 11, 2026
@wpbonelli
wpbonelli merged commit 6624a0e into modflowpy:develop Nov 11, 2026
17 of 18 checks passed
@wpbonelli
wpbonelli deleted the print-format branch November 11, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant