Repository navigation
keep blocks ending with a period number when trimming trailing text - #545
Merged
Merged
Conversation
When a file failed to parse, the reader cut it back to the last block _BLOCK_RE recognized and parsed again. The regex allowed one word after END, so END PERIOD 1 didn't end a block: the trim removed every period block and the second parse succeeded, silently losing the data. Allow anything after END, as MF6 does. Warn when the trim drops text, with the file and the lines. Update test021_twri's snapshots, which recorded its RCHA without its recharge. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simulation.loadcould silently drop period blocks if there was any stray text afterwards. For example, inmf6/test/test021_twri,twri.rchhas MF2005 lines left after its last period block.ENDtags, as MF6 doestwri.rch: ignoring text after the last block (lines 11-13)Text blocks used to lose data silently by the same route, and now raises. That's stricter than MF6, which skips it, but no longer silent. Consider whether to accept it like MF6 later