feat(webui): name 5xx failures as server errors - #986
Merged
Merged
Conversation
- add an `errors.server` message and use it for 5xx responses in the toast bridge and the error boundary, instead of "request failed" or the network hint which misattribute a server-side fault - format the toast as `status: headline` so the code leads and the phrase says whose fault it is
- extract the failure-to-text logic into `describeFailure` in the api layer and call it from the toast bridge instead of inlining it - throw an `ApiError` from the chat-stream guard so a failed turn carries the status and any backend message - describe failed chat turns through the same helper so they read like a failed REST call
alcholiclg
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errors.servermessage ("Server error — please try again later" / "服务器出错了，请稍后重试")describeFailurehelper in the api layer: the backend's own message when it sent one, otherwise the HTTP status first (502 Bad Gateway) and a server-vs-client headline second, with 5xx named a server error instead of "request failed" or the network hintApiErrorfrom the chat-stream guard so a failed turn carries the status and any backend message, and describe failed chat turns through the same helperTest
pnpm typecheck