fix: preserve generated vision token text embeddings - #207
Merged
tastelikefeet merged 1 commit intoSep 25, 2026
Merged
tastelikefeet merged 1 commit into
tastelikefeet merged 1 commit into
Conversation
tastelikefeet
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an autoregressive multimodal sequence contains a generated image/video special token, matching visual embedding positions by token ID alone also selects that generated token. This can misalign visual features or fail during embedding scatter.
Use optional
mm_token_type_ids(0=text, 1=image, 2=video) to select real visual input positions while preserving generated special-token IDs, text embeddings, and gradients. Validate shape, modality, placeholder IDs, payload presence, and feature counts. Callers without modality types retain token-ID-based selection, with explicit feature-count validation.Validation:
Scope: callers must supply correct input-aligned modality types to distinguish generated special tokens. This change only covers the shared
HuggingFaceVitembedding helper; it does not modify generation or model-specific mRoPE handling.