Add root lock mode, battery optimization prompt, and onboarding/UX improvements - #46
Open
nellocarotenuto wants to merge 6 commits into
Open
Add root lock mode, battery optimization prompt, and onboarding/UX improvements#46nellocarotenuto wants to merge 6 commits into
nellocarotenuto wants to merge 6 commits into
Conversation
- Added detailed KDoc comments to various classes and functions to improve code readability and maintainability. - Updated `TapLockAppRules.kt` with explanations for app exclusion rules and package management. - Enhanced `TapLockBatteryOptimization.kt` with comments on intent builders for battery optimization. - Improved documentation in `TapLockEdgeZones.kt`, `TapLockFeedback.kt`, `TapLockFloatingButtonConfig.kt`, `TapLockLockZone.kt`, `TapLockStatusBarZone.kt`, `TapLockTileService.kt`, `TapLockWidgetProvider.kt`, `TapLockWidgetStyle.kt`, `TapZoneMode.kt`, `Utils.kt`, `VibrationHelper.kt`, and `WidgetComponents.kt` to clarify functionality and usage. - Added comments to `Theme.kt` to describe the app-wide theme configuration.
- Updated README with instructions for root option visibility. - Enhanced root detection logic in RootLock.kt. - Added root note string to InfoSection and onboarding flow. - Updated accessibility settings intent for better user experience. - Translated new strings for root lock mode in both English and Spanish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New features
Root lock mode (opt-in, rooted devices only)
RootLockimplementation that locks by injectingKEYCODE_POWERthrough a persistentsushell — the screen turns off instantly with no lock-screen flicker, exactly like a physical power button press.su -c id) runs off the main thread with a generous timeout for the superuser grant dialog.which sufallback.suonly at process start) and the force-close/pre-grant workarounds.Battery optimization prompt
Onboarding & UX improvements
requestPinAppWidget) directly via an "Add Widget" button, instead of only describing manual steps; launchers without pin support keep the old instructions.:settings:fragment_args_keyextras, so users find the right row immediately. Applied to the permission dialog, onboarding, and the Quick Settings tile fallback.All strings added in both English and Spanish.
Verification
./gradlew assembleDebug+ manual testing on a physical device (onboarding flow, widget pinning, root lock with Magisk, accessibility settings highlight).