Consolidate TP support and validate vLLM and SGLang - #5
Draft
rchalamala wants to merge 119 commits into
Draft
Conversation
Signed-off-by: xenshinu <[email protected]>
Co-Authored-By: Rahul Chalamala <[email protected]> Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Rahul Chalamala <[email protected]> Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Rahul Chalamala <[email protected]> Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Rahul Chalamala <[email protected]> Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Rahul Chalamala <[email protected]> Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Rahul Chalamala <[email protected]> Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Signed-off-by: xenshinu <[email protected]>
Co-authored-by: Rahul Chalamala <[email protected]>
Co-authored-by: Rahul Chalamala <[email protected]>
Co-authored-by: Rahul Chalamala <[email protected]>
Co-authored-by: Rahul Chalamala <[email protected]>
Co-authored-by: Rahul Chalamala <[email protected]>
Co-authored-by: Rahul Chalamala <[email protected]>
Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Co-authored-by: Rahul Chalamala <[email protected]>
Add semantic archive fingerprints for symmetric-memory and shape-state manifests, poll LOAD logs until every expected replay batch appears, and preserve validation_report.json across run cleanup. Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Enable SGLANG_LOG_DECODE_GRAPH_KEY and read key_size from Decode graph replay (bs) lines so padded batch-8 replays are not misread as raw_bs 7. Co-authored-by: Rahul Chalamala <[email protected]>
Generate four fallback tokens so requests reach decode, parse cuda graph: False batch sizes, wait for eager evidence on LOAD, and gate on observed eager batch >= max captured shape + 1. Co-authored-by: Rahul Chalamala <[email protected]>
Add min_new_tokens and ignore_eos to generate requests for max+1 fallback while keeping normal sampling params unchanged for other callers. Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Rahul Chalamala <[email protected]>
Replace ThreadPool per-request scheduling with list-valued /generate calls so exact batch sizes reach decode without HTTP arrival coalescing. Co-authored-by: Rahul Chalamala <[email protected]>
Match SGLang capture reuse order during SAVE/SAVE2/LOAD sweeps to avoid transient cuMemCreate HOOK errors from ascending allocation growth. Co-authored-by: Rahul Chalamala <[email protected]>
Check duplicate keys before sorting descending in graph_batch_exercise_order. Co-authored-by: Rahul Chalamala <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main.SGLang symmetric-memory fix
PyTorch symmetric memory owns process-local virtual mappings and device pointer tables. SAVE preserves full graph JSON and a versioned backend/state record; LOAD rebuilds required SGLang warmup state, validates the exact TP=2 BF16 two-shot ABI and copy/dependency topology, and relocates every supported external operand to the live communicator.
The supported scope is intentionally fail-closed:
SGLANG_CUDA_GRAPH_MAX_BS=1).Verification
42 passedacross the final CPU TP contract suite.pre-commit run --all-files: all hooks passed.vllm-tp-8afbfda61de-1784771242076820717).8383c4db4d9e6459a6238960-1784839292861701133, including reproducible semantic fingerprints and offsets, one graph restored per rank at68555898880, byte-identical deterministic outputs, successful eager batch fallback, successful graph replay afterward, and no runtime errors.Multi-shape follow-up
docs/superpowers/specs/2026-07-23-sglang-multishape-symmetric-state-design.mddocs/superpowers/plans/2026-07-23-sglang-multishape-symmetric-state.mdThe plan retains SGLang's shared graph pool while introducing explicit per-shape FlashInfer state capsules, typed graph-operand manifests, exact pinned ABI validation, and staged 1+8 → 1+8+32 → full-inventory H100 gates.
Scope
This validates pinned experimental TP recipes, not general TP across arbitrary models, GPU counts, graph-shape inventories, or collective versions. General/official TP remains tracked upstream.