Repository navigation
Re-run the notebooks after the packed-bed fix, and tag the coupled shim - #55
Merged
Merged
Conversation
Re-run every example notebook, so the packed-bed outputs include the wall-conductivity fix (F-056). The stored energy of the default charge is now 2.32 kWh (was 2.30), and the design study's packed bed delivers 1.27 kWh (was 1.28). Give the fit to Nallusamy et al. (2007) at the four heights in the packed-bed notebook (0.68 K to 1.85 K RMS). compat/coupled.py now names pybamm-team/PyBaMM#6001 and its fix, PR #6002, which must land before the default can change. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Add a "Mesh and solver tolerance" section to the packed-bed page: the default 40 capsule points leave wiggles of a few hundredths of a kelvin as surface cells melt, gone at 80 points, and the energy error is the solver's. Explain in the packed-bed example the averaged outlet's second dip after its peak, which does not change with the mesh. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packed_bed_models). The design study's packed bed delivers 1.27 kWh, down from 1.28 kWh, still 52 % of what it stores.compat/coupled.py: the docstring now names [Bug]: resolve_coupled_variables=True breaks for boundary conditions and modifies the input model pybamm-team/PyBaMM#6001 and its fix, PR #6002. That fix must land before PyBaMM can resolve coupled variables by default. The issue asking for that default is still not filed (see Track upstream PyBaMM fixes, towards an empty compat/ #39).The new runs saved QuickPlot widget state into four notebooks that had none before. I removed it, so each notebook stores the same kind of metadata as before.
Checks
ruff checkandruff format --checkpass on the whole repository, notebooks included.🤖 Generated with Claude Code