Fix sfadamw jax v2 - #52
Merged
Merged
Conversation
Previously we were normalizing y based on historical data on x.(use_running_average_bn in the model would be true if update_batch_norm=false, and that contains historical bn based on x) Now it is updated to: 1.normalize y based on current batch norm data of y 2.normalize x based on historical bn of x 3. jit x batch norm update This aligns with pytorch implementation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
priyakasimbeg
approved these changes
Aug 28, 2026
priyakasimbeg
left a comment
priyakasimbeg
left a comment
Contributor
There was a problem hiding this comment.
Great catch! thank you Yifan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the code was normalizing y based on historical data on x.(use_running_average_bn in the model is set to true if update_batch_norm=false, and that running_average_bn derives from historical bn based on x) Now it is updated to:
This aligns with the pytorch implementation
comparison of validation accuracy before and after this PR:
