Skip to content

Make the analytic FACE comparison sign-invariant - #52

Merged
mlakolar merged 1 commit into
masterfrom
codex/fda-34-sign-test
Oct 25, 2026
Merged

mlakolar merged 1 commit into
masterfrom
codex/fda-34-sign-test

Conversation

@mlakolar

@mlakolar mlakolar commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

The noiseless rank-one FACE/dense test can fail when roundoff-sized fitted means legitimately select opposite eigenfunction signs. Align the analytic eigenfunction and score comparisons with one shared sign at the existing 1e-12 tolerance, and separately check each fit against its own documented mean-alignment or largest-entry fallback rule.

This changes only the analytic test. Estimator code, sign policy, signed R references, and their tolerances are unchanged.

Validation: full Discovery Julia 1.13.2 suite passes 6,315/6,315 tests with one Julia/BLAS thread (job 13424629). All four Julia 1.10/current × Ubuntu/macOS CI jobs, documentation, and Codecov checks pass on head 02b86d6563449a49735f4fd068dc41f0f466de2a. Project coverage is unchanged at 98.36%. Naming and whitespace checks pass.

Closes #34. Part of #33. Targets master, where prerequisite #32 was merged.

@codecov

codecov Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.36%. Comparing base (23e95e6) to head (02b86d6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files          31       31           
  Lines        3606     3606           
=======================================
  Hits         3547     3547           
  Misses         59       59           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mlakolar
mlakolar merged commit 3f74f6c into master Oct 25, 2026
7 checks passed
@mlakolar
mlakolar deleted the codex/fda-34-sign-test branch October 25, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant