Repository navigation
Make the analytic FACE comparison sign-invariant - #52
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 31 31
Lines 3606 3606
=======================================
Hits 3547 3547
Misses 59 59 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
18 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The noiseless rank-one FACE/dense test can fail when roundoff-sized fitted means legitimately select opposite eigenfunction signs. Align the analytic eigenfunction and score comparisons with one shared sign at the existing
1e-12tolerance, and separately check each fit against its own documented mean-alignment or largest-entry fallback rule.This changes only the analytic test. Estimator code, sign policy, signed R references, and their tolerances are unchanged.
Validation: full Discovery Julia 1.13.2 suite passes 6,315/6,315 tests with one Julia/BLAS thread (job 13424629). All four Julia 1.10/current × Ubuntu/macOS CI jobs, documentation, and Codecov checks pass on head
02b86d6563449a49735f4fd068dc41f0f466de2a. Project coverage is unchanged at 98.36%. Naming and whitespace checks pass.Closes #34. Part of #33. Targets
master, where prerequisite #32 was merged.