Repository navigation
A PrecompileTools workload for the estimators - #11
Merged
Merged
Conversation
The first estimate of each kind compiled the whole three-stage estimator: 0.3 to 1.6 s for SymmetricNormal, AsymmetricNormal, SeparateNormal, ReducedNormal and the bootstrap. src/precompile.jl compiles them, in Float64, into the package image. In fresh processes their first calls take 0 to 56 ms on Julia 1.13 and 1.10; `using DiffPrecTest` takes as long as before on 1.13 and about 20 ms more on 1.10, and precompilation 3.5 s instead of 0.9 s. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 98.45% 98.62% +0.16%
==========================================
Files 12 13 +1
Lines 1294 1306 +12
==========================================
+ Hits 1274 1288 +14
+ Misses 20 18 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/precompile.jladds a PrecompileTools workload, inFloat64on a small problem (p = 5, n = 300). It coversestimatewithSymmetricNormal,AsymmetricNormal,SeparateNormalandReducedNormal, andbootstrapwithsimulCIstudentized. The calls of ProximalSolvers, CovarianceSelection and ProximalBase that they make are cached with them.Measurements
Fresh processes on the Mac (M3 Pro), with each call evaluated at top level after
using DiffPrecTest; p = 8, n = 400, entry (3, 2). First call, in seconds:SymmetricNormalAsymmetricNormalSeparateNormalReducedNormalbootstrap,simulCIstudentizedCosts:
using DiffPrecTesttakes the same time as on master on 1.13 (median 0.46 s) and about 20 ms more on 1.10 (0.38 s against 0.36 s).The other dependencies are unregistered masters, so these measurements took ProximalBase, ProximalSolvers and CovarianceSelection from their masters. The PrecompileTools workloads of ProximalSolvers (mlakolar/ProximalSolvers.jl#44, merged) and CoordinateDescent (mlakolar/HighDimensionalModels.jl#47) come separately.
PrecompileTools' preference
precompile_workload = falseskips the workload; the compat is"1", since 1.3 does not install on Julia 1.10.Tests
Pkg.test()with--depwarn=errorpasses all 20172 tests:[sources];🤖 Generated with Claude Code