fix(labeling): remove grouped as-of sortedness warning - #61
Merged
Merged
Conversation
Validate timestamp order within each group before disabling Polars grouped sortedness checks, removing the false warning without accepting unordered input. Closes #59.
stefan-jansen
added this to the
0.1.5 - Correct labeling warnings and risk annualization milestone
stefan-jansen
marked this pull request as ready for review
September 24, 2026 09:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
uv run pytest tests/labeling/test_time_horizons.py -q(57 passed)uv run pytest tests/ -q(3928 passed, 57 deselected)uv run ruff check src/ tests/ examples/ scripts/uv run ruff format --check src/ tests/ examples/ scripts/uv run ty checkuv builduv run python -c "import ml4t.engineer"uv run mkdocs build --strictCloses #59.