Leak thread local streams on exit in main thread - #4576
Merged
Merged
Conversation
zcbenz
force-pushed
the
leak-thread-local-streams
branch
from
September 28, 2026 02:50
5e22365 to
e0d7788
Compare
aleroot
approved these changes
Sep 28, 2026
Collaborator
|
Thank you! |
nastya236
self-requested a review
September 28, 2026 13:36
nastya236
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #4480, so we don't automatically synchronize and destroy thread local streams on exit, which would fail when CUDA runtime exits earlier. Also solves part of #4506.