Adding VJP for gated delta net. - #4565
Draft
tpegolotti wants to merge 12 commits into
Draft
tpegolotti wants to merge 12 commits into
tpegolotti wants to merge 12 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding VJP kernels for the gated delta net. This PR continues the work started in #4020.
Two kernels are added, one for the sequential case (pure metal kernel) and one for the chunked case (using neural accelerator).
Performance
The benchmark sweeps the Gated Delta backward over batch sizes 1, 4 and 8 and sequence lengths from 8 to 4096, at Hk=16, Hv=32, Dk=Dv=128, comparing the sequential kernel, the chunked NAX kernel and the ops fallback.
The chunked kernel is 1.4x to 6.3x faster than the sequential one and 9x to 79x faster than the fallback.