chore: Fix assertion in ReduceScatter::eval_cpu - #4557
Merged
Merged
Conversation
Contributor
Author
|
This is ready for review, but it appears there's a limit how many PRs a person can open |
ronaldmannak
changed the title
Member
|
The limitation is set because we are unable to spend too much time reviewing contributor PRs at the moment, please do not open new PRs before we review your current open ones. |
Contributor
Author
|
@zcbenz Got it! I split changes into small PRs thinking it'd make reviewing easier for you :) I have a few more lined up, so I'll wait. BTW, does the one-PR-at-a-time rule also apply to mlx-swift? |
Member
|
mlx-swift receives much less PRs so it does not have the restriction, but I think it is generally good practice not to open too much PRs at the same time. |
zcbenz
marked this pull request as ready for review
September 25, 2026 01:10
zcbenz
approved these changes
Sep 28, 2026
zcbenz
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReduceScatter::eval_cpuis assertinginputs.size() == 0while reading the first element, thus aborting valid calls when assertions are enabled.This PR asserts
inputs.size() == 1.