Add Python 3.15 and 3.15t support - #4555
Merged
Merged
Conversation
zcbenz
reviewed
Sep 28, 2026
zcbenz
left a comment
Member
There was a problem hiding this comment.
Running test_bindings.py with debug build DEBUG=1 setup.py build_ext -i gets critical error:
Critical nanobind error: attempted to change the reference count of a Python object or to call into Python while the GIL was not held!
Member
|
There is also a weird error when building wheel https://github.com/ml-explore/mlx/actions/runs/36394870740/job/108838778494: |
Contributor
Author
|
Some translation units included standard headers before This 2 problems are all fixed now |
Let garbage-collected wrappers own C++ callbacks so compiled caches and captured objects are released. Keep the random state sentinel alive without a Python reference-count operation during static destruction.
Keep the structure sentinel alive without Python reference-count operations during static destruction. Add a subprocess regression test for compiled-function shutdown.
Include Python headers before standard headers in binding translation units to avoid feature macro redefinition errors with Python 3.15.
zcbenz
force-pushed
the
python-3.15-support
branch
from
September 29, 2026 09:14
0e4e5e1 to
9d316f7
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Python 3.15 and 3.15t to the release wheel matrix. Update
nanobindfrom 3.0.1 to 3.1.0 and align the extension build configuration and documentation with free-threaded support.Freeze bound types on Python 3.15 to enable Python immutable type optimizations. This prevents runtime changes to attributes on those types.
Tests on Python 3.15t also exposed two lifetime issues: