Skip to content

fix(CUDA): Do not throw from ~CudaHandle while the driver is unloading #4531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
inureyes wants to merge 2 commits into from
Closed

fix(CUDA): Do not throw from ~CudaHandle while the driver is unloading #4531

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82b6b1d
[CUDA] Do not throw from ~CudaHandle while the driver is unloading
inureyes Sep 18, 2026
e9d5b30
Merge branch 'main' into fix/cuda-handle-destructor-no-throw
inureyes Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion mlx/backend/cuda/cuda_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,13 @@ class CudaHandle {
if (cudaPeekAtLastError() != cudaSuccess) {
return;
}
reset();
// Not reset(): it throws via CHECK_CUDA_ERROR, and a throw escaping a
// destructor terminates. At exit the runtime may already be unloading, so
// Destroy fails and the handle can no longer be reclaimed or reported on.
if (handle_ != nullptr) {
Destroy(handle_);
handle_ = nullptr;
}
}

CudaHandle(const CudaHandle&) = delete;
Expand Down