Conversation
dhiltgen
force-pushed
the
sdpa-prenax-d512
branch
from
September 15, 2026 19:10
4516aae to
421beb3
Compare
zcbenz
marked this pull request as ready for review
September 24, 2026 00:36
dhiltgen
force-pushed
the
sdpa-prenax-d512
branch
2 times, most recently
from
September 25, 2026 15:53
e524899 to
34d92e0
Compare
zcbenz
reviewed
Sep 27, 2026
| test_grad(loss_slow, loss_fast, [q, k, v]) | ||
|
|
||
| @unittest.skipIf(not mx.metal.is_available(), "Metal kernel path only") | ||
| def test_sdpa_d512_default_metal(self): |
Member
There was a problem hiding this comment.
Can you merge the test to test_sdpa_full_head_dim_256?
dhiltgen
force-pushed
the
sdpa-prenax-d512
branch
from
September 28, 2026 15:40
34d92e0 to
c5d2f8c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps improve the memory usage of D512 attention on M4 and older GPUs with models such as gemma4.
Testing with
mlx-community/gemma-4-31b-it-nvfp4andmlx-community/gemma-4-12B-it-nvfp4via mlx_lm.benchmark g128Gemma 4 12BmainGemma 4 12BGemma 4 31BmainGemma 4 31BGemma 4 12BmainGemma 4 12B