whisper: only package mlx_whisper in the wheel - #1455
Open
Kayvan-Zahiri wants to merge 1 commit into
Open
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
find_namespace_packages() with no include picks up a leftover build/ directory, so the mlx-whisper 0.4.3 wheel ships build/lib/... as a top-level namespace package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mlx-whisper 0.4.3 wheel on PyPI installs a top-level
builddirectory next tomlx_whisper:setup.pyusesfind_namespace_packages()with no filter. Namespace discovery also picks up directories without an__init__.py, so once a previous build has leftwhisper/build/lib/mlx_whisper/...behind, the next build packages it asbuild.lib.mlx_whisper. It reproduces locally: building twice in a clean checkout ofmain, the second wheel has 12 files underbuild/.This restricts discovery to
find_namespace_packages(include=["mlx_whisper*"]), which keeps themlx_whisper.assetsdata and drops everything else. With the change, both the first and second builds contain onlymlx_whisper, and the files undermlx_whisper/are identical to a first build ofmain.