Skip to content

Fix trusted GeoIP header default behavior - #40

Merged
mkaand merged 1 commit into
mainfrom
fix/geoip-header-default
Oct 4, 2026
Merged

mkaand merged 1 commit into
mainfrom
fix/geoip-header-default

Conversation

@mkaand

@mkaand mkaand commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Populate an empty trusted country-header field with CF-IPCountry when Trusted country header mode is selected.
  • Preserve existing custom and persisted header values.
  • Keep the existing server-side blank-header validation unchanged.

Scope and safety

  • The default is an actual input value, not a placeholder.
  • No GeoIP resolver, analytics, database, settings persistence, or production configuration behavior changed.
  • Public frontend files are unchanged.

Tests

  • Added server-rendering coverage for empty, default, and custom trusted-header values plus existing validation paths.
  • Added an admin DOM behavior test for the None-to-Trusted transition and custom-header preservation.
  • Ran focused PHP and JavaScript tests, Python checks, frontend build/audit checks, and Docker build validation locally.

@mkaand
mkaand merged commit 6c9a0d0 into main Oct 4, 2026
4 checks passed
@mkaand
mkaand deleted the fix/geoip-header-default branch October 4, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant