Document #618/#655 reconciliation decision in github.ts header

[itsmiso-ai]

What

Closes #618 as declined and documents the reconciliation in #655 by converting four facade files (github-auth.ts, github-ci.ts, github-code-search.ts, github-issues.ts) from export * from "./github" to export {}, adding a comment block in each explaining th…

Fixes #655

Opened by foreman on review GO (workload wl-misospace-dispatch-655).

[its-saffron]

AI Automated Review

Full PR review.

Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — routed smart (risk match: auth_changes)

Recommendation: Approve

This PR correctly documents the reconciliation decision from PR 655. It converts four facade files from misleading export * from "./github" re-exports to intentionally empty modules (export {}) with documentation comments explaining the decision. The actual GitHub client code in github.ts is untouched.

Change-by-Change Findings

src/lib/github-auth.ts (auth_changes flag triggered)

• Before: export * from "./github" (misleading — implied domain-specific auth module existed)
• After: export {} with JSDoc explaining the facade was declined by PR 655
• Auth flow impact: None. The export * re-export never added real value — callers already had to understand the underlying github.ts dependency. The actual GITHUB_TOKEN handling, JWT setup, and GitHub authentication live in github.ts (unchanged by this PR). No callers were depending on github-auth.ts as a typed boundary.

src/lib/github-ci.ts, src/lib/github-code-search.ts, src/lib/github-issues.ts

• Same pattern as github-auth.ts. Empty modules with documentation. No functional impact.

src/lib/github.ts

• Added module-level JSDoc header explaining why it remains a single ~1000-line module and referencing the sibling facade files and PR 655.

src/lib/github-facades.test.ts (new)

• Regression test verifying all four facades export zero named exports.
• Uses Object.keys(mod).sort()).toEqual([]) assertion.
• Covers the exact regression risk: someone accidentally restoring export * from "./github".

---

Required Check Results

✅ Review auth flow for regression

The auth_changes risk flag points to src/lib/github-auth.ts. Verification:

• The diff replaces export * from "./github" with export {} — no code logic changed.
• The real GitHub auth implementation (JWT setup, GITHHubToken creation, API client instantiation) remains in github.ts unchanged.
• No callers import from github-auth.ts specifically for auth functions — the facade was purely a re-export with no added value.
• The session token handling (bearer tokens via DISPATCH_AGENT_TOKEN) is in lib/auth.ts, which is unaffected by this PR.

✅ Verify session token handling is correct

Session token handling is handled by lib/auth.ts (authorizeRequest, getAuthorizedActor) for the app, and GITHUB_TOKEN for the GitHub client in github.ts. Neither file is touched by this PR. The github-auth.ts facade never contained session token logic — it was only a re-export of github.ts.

---

Standards Compliance

• No agent-specific names in generic docs: ✅ N/A — no docs added.
• Error handling: ✅ N/A — no runtime code changes.
• Validation: ✅ N/A — no inputs changed.
• No commit of secrets: ✅ No secrets introduced.
• API routes / Prisma: ✅ N/A — no API or schema changes.

---

Linked Issue Fit

Issue	Requirement	Status
PR 618	Split github.ts into domain modules (github-auth, github-issues, github-ci, github-code-search) with each under 400 lines	Declined by PR 655. This PR documents that decision and ensures facades remain empty.
PR 655	Close PR 618 as "sufficient" and document the decision, or split the module	This PR implements the "document the decision" path. Facades converted to empty export {} with comments. Regression test added.

---

Tool Harness Findings

No tool calls were issued; reviewing the corpus directly.

---

CI Check Results

All checks passed:

• ✅ Lint
• ✅ Docker Build
• ✅ Build
• ✅ Tests (includes new github-facades.test.ts)
• ✅ Typecheck

---

Unknowns / Needs Verification

None. The diff is self-contained, the regression test covers the specific risk, and CI confirms build/typecheck/test pass.