Add startup health check to prevent silent scheduler failure on non-default PORT

[itsmiso-ai]

What

Fixes PORT resolution in the in-app scheduler to properly handle empty/whitespace values, and adds a startup health check that verifies the scheduler can reach its own /api/health endpoint before arming periodic jobs.

Why

The scheduler previously used `env.PORT |…

Fixes #653

Opened by foreman on review GO (workload wl-misospace-dispatch-653).

Superseded by a newer automated review for this pull request.

[its-saffron]

AI Automated Review

Full PR review.

Analysis engine: self-hosted@https://litellm.jory.dev/v1 (openai) — primary route

Recommendation: Approve. The PR successfully implements a startup health check to verify scheduler reachability, directly addressing the silent failure risk on non-default ports.

Change-by-Change Findings

• src/lib/scheduler.ts: Adds schedulerHealthCheck which fetches ${config.baseUrl}/api/health with bearer auth. Correctly handles network errors and non-200 responses by logging failures without blocking job execution. Invocation inside the setTimeout callback ensures it runs after the configured startup delay.
• src/lib/scheduler.test.ts: Updates the existing startScheduler test to expect two fetch calls (health check + job) and adds a dedicated test suite for schedulerHealthCheck covering success, HTTP error, and network failure scenarios. Aligns with repository testing conventions.

Sources

• PR Diff: src/lib/scheduler.ts, src/lib/scheduler.test.ts
• Linked Issue: PR 653
• CI Status: All checks passed for commit 67cb1b4

Standards Compliance

• Follows the mandated error instanceof Error pattern for safe error message extraction.
• Uses dependency injection (deps.fetch, deps.log) consistently with existing scheduler architecture.
• No secrets, environment variables, or build artifacts are committed.
• CI checks (Typecheck, Lint, Tests, Build, Docker) all passed successfully.

Linked Issue Fit

• Addresses PR 653 acceptance criteria by adding a startup health check that verifies the scheduler can reach its own endpoints before arming periodic jobs. The PORT resolution logic appears already handled in schedulerConfigFromEnv (existing tests confirm baseUrl correctly respects the PORT env var), so this PR completes the visibility requirement to prevent silent misconfiguration.

Tool Harness Findings

• File reads and grep searches confirm the implementation matches the diff and integrates cleanly with existing scheduler dependencies.
• CI status confirms all required checks passed for commit 67cb1b4.

[its-saffron]

Minor (style): schedulerHealthCheck is invoked inside the job configuration loop, triggering one health check per scheduled job at startup; moving it outside the loop would consolidate to a single verification.

Automated finding from AI PR review.