Refines secret retrieval check to skip commented lines#40
Merged
Conversation
The dev/staging/prod trio was the same pipeline three times, and the drift it hid was real: prod built its image without waiting for lint or tests, staging and prod disagreed on deploy's needs list, and inference's prod migrate keyed its concurrency group on a matrix it does not have. One repo-local build-deploy.yml now holds the graph; the three callers hold the trigger, the concurrency group, the checks the build waits on, the permission ceiling, and the env knobs. migrate/deploy/integration-tests collapse to one matrixed path gated on a has-envs boolean, because an empty matrix concludes the whole run as failed with no failed job in it. Also fixes what the pipelines were saying. Two pushes to staging had concluded startup_failure with zero jobs -- a caller granted no pull-requests scope while a callee declared one, and that cap is enforced when the file loads -- so staging served the previous image for ten hours and nothing alerted, because the notify job is a job inside the run. Prevention is a shared lint gate, detection is a scheduled sweep; the same fix closed an unnoticed prod window. Promotion PRs stop rebuilding images nothing deploys, and a release is one run tree instead of two.
…NG-1053) Replaces `workflow_permissions.py` with `workflow_graph.py` to incorporate additional static checks on workflow graphs, addressing issues with multiple run trees and uncalled reusables. Updates related workflow and test references. Introduces `.gitignore` to exclude common Python and IDE-specific files.
Update README to provide clear guidelines on choosing secret storage locations based on the type of secret, emphasizing security considerations and correcting misconceptions about Kubernetes as the default. Removes redundant compiled Python file.
…orkflow robustness (ENG-1053) Enhances PR environment comment workflow by removing sensitive details, promoting security by linking to protected documentation, and refines permission declarations to prevent runtime failures. Updates README and test cases to reflect these changes, ensuring clarity and consistency. These improvements address previous detection gaps and enhance auditability for pull request-based operations.
…ments (ENG-1053) Introduces a new input option to customize the heading text in PR environment comments, accommodating varied use cases such as installer artifacts. Simplifies message consistency by updating the subtext. These changes provide greater flexibility and clearer communication in pull request comments.
…p-failure-watchdog
…1053) Adjusts the grep command to ignore commented lines when checking for secret retrieval commands in scripts, preventing false positives. This ensures that only executable lines accessing secrets are flagged, enhancing the reliability of workflow audits.
mindsdb-devops
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the workflow's secret retrieval check by ensuring it skips comments, preventing false positives when analyzing code. This enhances the security checks by focusing on executable commands, reducing unnecessary alerts.
Relates to ENG-1053