Repository navigation
Pass a column with failed data into a PFrame as an empty column - #2010
Draft
AStaroverov wants to merge 1 commit into
Draft
AStaroverov wants to merge 1 commit into
AStaroverov wants to merge 1 commit into
Conversation
resolvePColumnById reads the .data field with its error. A field that holds an error, with or without a value, yields an empty value list, as a field without a value yet already does, so one failed column no longer fails the whole PFrame or PTable.
🦋 Changeset detectedLatest commit: 06c1166 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2010 +/- ##
==========================================
+ Coverage 61.03% 61.05% +0.02%
==========================================
Files 444 444
Lines 24135 24137 +2
Branches 5692 5693 +1
==========================================
+ Hits 14730 14738 +8
+ Misses 7734 7723 -11
- Partials 1671 1676 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
One column whose data failed made
createPFrame,createPTableandcreatePTableV2fail for every column given with it. A block's table or graph then showed nothing but the error of a single column, for example after an out-of-memory in one step of the block that produces it.The host reads the
.datafield of each column it is given by id (resolvePColumnById). It read the field withignoreError, which does not help here:.datafieldparseDataInfoResource)Change
resolvePColumnByIdreads the field together with its error (getField). A field that holds an error, with or without a value, gives an empty value list — the same thing a field without a value yet already gives. The column stays in the frame with its spec and no values; the other columns are readable..specfield holds an error still fails the call: without a spec there is nothing to put in the frame.Compatibility
Ships with the desktop app; blocks need no rebuild. A V3 table still needs #2011 to show such a column as
error— without it the column is empty and its status is whatever the block's SDK reports.Not covered
createPFramestill fails on a failed data resource: the block has already read the field, and the error sits on the resource.Tests
lib/node/pl-middle-layer/src/js_render/column_registry.test.ts, over aPlTreeStatebuilt in the test, no backend needed: data that is there, an error without a value, an error with a value, a field without a value yet (not stable), and an errored spec (still throws). The two error cases fail onmain.