Skip to content

Pass a column with failed data into a PFrame as an empty column - #2010

Draft
AStaroverov wants to merge 1 commit into
mainfrom
fix/errored-column-data-in-frames
Draft

AStaroverov wants to merge 1 commit into
mainfrom
fix/errored-column-data-in-frames

Conversation

@AStaroverov

@AStaroverov AStaroverov commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

One column whose data failed made createPFrame, createPTable and createPTableV2 fail for every column given with it. A block's table or graph then showed nothing but the error of a single column, for example after an out-of-memory in one step of the block that produces it.

The host reads the .data field of each column it is given by id (resolvePColumnById). It read the field with ignoreError, which does not help here:

.data field Before
error, no value the read throws
error and a value the data resource is returned, and parsing it throws later (parseDataInfoResource)

Change

resolvePColumnById reads the field together with its error (getField). A field that holds an error, with or without a value, gives an empty value list — the same thing a field without a value yet already gives. The column stays in the frame with its spec and no values; the other columns are readable.

  • No new read: it is the same single read of the same field, so the subscriptions of the output are unchanged.
  • A column whose .spec field holds an error still fails the call: without a spec there is nothing to put in the frame.

Compatibility

Ships with the desktop app; blocks need no rebuild. A V3 table still needs #2011 to show such a column as error — without it the column is empty and its status is whatever the block's SDK reports.

Not covered

Tests

lib/node/pl-middle-layer/src/js_render/column_registry.test.ts, over a PlTreeState built in the test, no backend needed: data that is there, an error without a value, an error with a value, a field without a value yet (not stable), and an errored spec (still throws). The two error cases fail on main.

resolvePColumnById reads the .data field with its error. A field that holds an error, with or without a value, yields an empty value list, as a field without a value yet already does, so one failed column no longer fails the whole PFrame or PTable.
@changeset-bot

changeset-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 06c1166

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@milaboratories/pl-middle-layer Patch
@platforma-sdk/pl-cli Patch
@platforma-sdk/test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.05%. Comparing base (bbe5bd0) to head (06c1166).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2010      +/-   ##
==========================================
+ Coverage   61.03%   61.05%   +0.02%     
==========================================
  Files         444      444              
  Lines       24135    24137       +2     
  Branches     5692     5693       +1     
==========================================
+ Hits        14730    14738       +8     
+ Misses       7734     7723      -11     
- Partials     1671     1676       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant