Repository navigation
MILAB-6300: refuse a backend that requires unknown client capabilities - #2006
Merged
Merged
Conversation
LLPlClient.build() reads Ping.Response.required_capabilities right after the first Ping and throws ClientUpdateRequiredError when the client does not implement a listed token. The REST ping maps the missing field to an empty list.
🦋 Changeset detectedLatest commit: 5b7f522 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
xnacly
marked this pull request as ready for review
November 13, 2026 13:36
Contributor
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2006 +/- ##
==========================================
+ Coverage 60.42% 60.46% +0.04%
==========================================
Files 443 443
Lines 23627 23639 +12
Branches 5535 5537 +2
==========================================
+ Hits 14276 14293 +17
+ Misses 7712 7706 -6
- Partials 1639 1640 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- carry the reworded proto contract into the vendored proto and both type sets - test that build() closes the client when it refuses the backend - test the wire protocol autodetect path and the REST mapping of an absent field
…lient-capabilities
…lient-capabilities
DenKoren
approved these changes
Nov 13, 2026
Co-authored-by: Denis Korenevskiy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLPlClient.build()checksPing.Response.required_capabilitiesright after the first Ping and throwsClientUpdateRequiredError(no other request reaches the backend) when the client lacks a listed tokensupportedClientCapabilities()lists the client tokens; empty for nowproto-rest/plapi.tsis edited by hand in the generator's format, becauseopenapi-typescriptfails under TypeScript 7Backend: milaboratory/pl#2459