Skip to content

MILAB-6300: refuse a backend that requires unknown client capabilities - #2006

Merged
xnacly merged 5 commits into
mainfrom
MILAB-6300/required-client-capabilities
Nov 13, 2026
Merged

xnacly merged 5 commits into
mainfrom
MILAB-6300/required-client-capabilities

Conversation

@xnacly

@xnacly xnacly commented Nov 13, 2026

Copy link
Copy Markdown
Member
  • LLPlClient.build() checks Ping.Response.required_capabilities right after the first Ping and throws ClientUpdateRequiredError (no other request reaches the backend) when the client lacks a listed token
  • supportedClientCapabilities() lists the client tokens; empty for now
  • REST ping maps an absent field to an empty list (old backends)
  • only the new field is applied to the synced protos: the local copy lags pl main, and a full sync would pull unrelated changes. proto-rest/plapi.ts is edited by hand in the generator's format, because openapi-typescript fails under TypeScript 7

Backend: milaboratory/pl#2459

LLPlClient.build() reads Ping.Response.required_capabilities right after the
first Ping and throws ClientUpdateRequiredError when the client does not
implement a listed token. The REST ping maps the missing field to an empty list.
@changeset-bot

changeset-bot Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5b7f522

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@milaboratories/pl-client Minor
@milaboratories/pl-model-backend Patch
@milaboratories/pl-errors Patch
@milaboratories/pl-tree Patch
@milaboratories/pl-drivers Patch
@milaboratories/pl-middle-layer Patch
@platforma-sdk/pl-cli Patch
@platforma-sdk/test Patch
@platforma-sdk/tengo-builder Patch
@platforma-sdk/block-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@notion-workspace

Copy link
Copy Markdown

@xnacly
xnacly marked this pull request as ready for review November 13, 2026 13:36
@greptile-apps

greptile-apps Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Automatic reviews are disabled for this repository. Configure in Code Review Settings.

@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.46%. Comparing base (ec893f4) to head (5b7f522).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2006      +/-   ##
==========================================
+ Coverage   60.42%   60.46%   +0.04%     
==========================================
  Files         443      443              
  Lines       23627    23639      +12     
  Branches     5535     5537       +2     
==========================================
+ Hits        14276    14293      +17     
+ Misses       7712     7706       -6     
- Partials     1639     1640       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- carry the reworded proto contract into the vendored proto and both type sets
- test that build() closes the client when it refuses the backend
- test the wire protocol autodetect path and the REST mapping of an absent field
Co-authored-by: Denis Korenevskiy <[email protected]>
@xnacly
xnacly enabled auto-merge November 13, 2026 15:21
@xnacly
xnacly added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit e644964 Nov 13, 2026
19 of 21 checks passed
@xnacly
xnacly deleted the MILAB-6300/required-client-capabilities branch November 13, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants